Skip to content

refactor!: remove discord.js builders #10529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 5, 2025
Merged

refactor!: remove discord.js builders #10529

merged 11 commits into from
Mar 5, 2025

Conversation

didinele
Copy link
Member

@didinele didinele commented Oct 2, 2024 •
edited
Loading

>:)

BREAKING CHANGE: Removed all builder extensions within discord.js

Upcoming follow-ups:

  • re-think discord.js' jank AttachmentBuilder and potentially move it, in some form, to /builders
  • implement a MessageBuilder within builders
  • as of this PR, users would get the following diff:
-   .setEmoji('😏')
+  .setEmoji(resolvePartialEmoji('😏'))

we can:

  1. stick to that
  2. move those functions to /builders (still stick to that API, though)
  3. along with 2., allow those simplified types in setX() methods within builders

@didinele didinele added this to the discord.js 15.0.0 milestone Oct 2, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 0:32am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 0:32am

Syjalo

This comment was marked as off-topic.

Sign in to view

@didinele didinele force-pushed the refactor/builders-v2-mainlib branch from e2b9bc7 to 97f9acf Compare October 9, 2024 09:10
@Jiralite Jiralite mentioned this pull request Dec 5, 2024
Merged
@Jiralite Jiralite force-pushed the refactor/builders-v2-mainlib branch from 97f9acf to a67bdf9 Compare December 24, 2024 20:09
@Jiralite Jiralite dismissed Syjalo’s stale review December 24, 2024 20:10

This will be done on release.

@didinele didinele force-pushed the refactor/builders-v2-mainlib branch 2 times, most recently from a4c9a0f to cb1fedf Compare February 26, 2025 14:06
@didinele didinele changed the title refactor: use builders v2 in mainlib refactor: remove discord.js builders Feb 26, 2025
@didinele didinele marked this pull request as ready for review February 26, 2025 14:09
@didinele didinele requested a review from a team as a code owner February 26, 2025 14:09
@Jiralite Jiralite changed the title refactor: remove discord.js builders refactor!: remove discord.js builders Feb 26, 2025
Qjuh
Qjuh requested changes Feb 26, 2025
View reviewed changes
Qjuh
Qjuh requested changes Feb 26, 2025
View reviewed changes
@didinele didinele requested a review from Qjuh February 27, 2025 13:05
Qjuh
Qjuh requested changes Feb 27, 2025
View reviewed changes
Jiralite
Jiralite requested changes Feb 27, 2025
View reviewed changes
@didinele didinele requested a review from Jiralite February 27, 2025 21:23
@Jiralite
Copy link
Member

It seems there's a circular dependency somewhere:

import "discord.js";

(node:41103) Warning: Accessing non-existent property 'createComponent' of module exports inside circular dependency

@didinele
Copy link
Member Author

It seems there's a circular dependency somewhere:

should be fixed

Jiralite
Jiralite previously approved these changes Feb 28, 2025
View reviewed changes
vladfrangu
vladfrangu previously requested changes Mar 1, 2025
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing this, it can be merged without needing my approval again 🫡

@github-project-automation github-project-automation bot moved this from Review Approved to Review in Progress in discord.js Mar 1, 2025
@didinele didinele requested a review from a team as a code owner March 2, 2025 11:50
@didinele didinele requested a review from vladfrangu March 2, 2025 11:50
@didinele didinele marked this pull request as draft March 2, 2025 15:21
@didinele didinele force-pushed the refactor/builders-v2-mainlib branch from 403a6f6 to e90f16e Compare March 5, 2025 12:28
@didinele didinele force-pushed the refactor/builders-v2-mainlib branch from e90f16e to f0a5638 Compare March 5, 2025 12:32
@didinele didinele marked this pull request as ready for review March 5, 2025 12:32
@didinele
Copy link
Member Author

didinele commented Mar 5, 2025

After a multitude of internal discussions and attempts, Vlad's request will ultimately be left unresolved for the time being.

@didinele didinele merged commit 0f89353 into main Mar 5, 2025
8 checks passed
@didinele didinele deleted the refactor/builders-v2-mainlib branch March 5, 2025 12:34
@github-project-automation github-project-automation bot moved this from Review in Progress to Done in discord.js Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet approved these changes

@Jiralite Jiralite Jiralite approved these changes

@Qjuh Qjuh Qjuh approved these changes

@Syjalo Syjalo Syjalo left review comments

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu was automatically assigned from discordjs/builders

Assignees
No one assigned
Labels
packages:discord.js refactor semver:major
Projects
discord.js
Archived in project
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@didinele @Jiralite @vladfrangu @kyranet @Syjalo @Qjuh